lkml.org 
[lkml]   [2020]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 11/20] bpf: factor out a bpf_trace_copy_string helper
On Tue, May 19, 2020 at 6:45 AM Christoph Hellwig <hch@lst.de> wrote:
>
> + switch (fmt_ptype) {
> + case 's':
> +#ifdef CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE
> + strncpy_from_unsafe(buf, unsafe_ptr, bufsz);
> + break;
> +#endif
> + case 'k':
> + strncpy_from_kernel_nofault(buf, unsafe_ptr, bufsz);
> + break;

That 's' case needs a "fallthrough;" for the overlapping case,
methinks. Otherwise you'll get warnings.

Linus

\
 
 \ /
  Last update: 2020-05-19 18:08    [W:0.221 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site