| From | Linus Torvalds <> | Date | Tue, 19 May 2020 09:07:55 -0700 | Subject | Re: [PATCH 11/20] bpf: factor out a bpf_trace_copy_string helper |
| |
On Tue, May 19, 2020 at 6:45 AM Christoph Hellwig <hch@lst.de> wrote: > > + switch (fmt_ptype) { > + case 's': > +#ifdef CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE > + strncpy_from_unsafe(buf, unsafe_ptr, bufsz); > + break; > +#endif > + case 'k': > + strncpy_from_kernel_nofault(buf, unsafe_ptr, bufsz); > + break;
That 's' case needs a "fallthrough;" for the overlapping case, methinks. Otherwise you'll get warnings.
Linus
|