lkml.org 
[lkml]   [2020]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/4] Relocate execve() sanity checks
Kees Cook <keescook@chromium.org> writes:

> Hi,
>
> While looking at the code paths for the proposed O_MAYEXEC flag, I saw
> some things that looked like they should be fixed up.
>
> exec: Change uselib(2) IS_SREG() failure to EACCES
> This just regularizes the return code on uselib(2).
>
> exec: Relocate S_ISREG() check
> This moves the S_ISREG() check even earlier than it was already.
>
> exec: Relocate path_noexec() check
> This adds the path_noexec() check to the same place as the
> S_ISREG() check.
>
> fs: Include FMODE_EXEC when converting flags to f_mode
> This seemed like an oversight, but I suspect there is some
> reason I couldn't find for why FMODE_EXEC doesn't get set in
> f_mode and just stays in f_flags.

So I took a look at this series.

I think the belt and suspenders approach of adding code in open and then
keeping it in exec and uselib is probably wrong. My sense of the
situation is a belt and suspenders approach is more likely to be
confusing and result in people making mistakes when maintaining the code
than to actually be helpful.

Eric

\
 
 \ /
  Last update: 2020-05-19 17:11    [W:1.077 / U:2.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site