Messages in this thread | | | Date | Tue, 19 May 2020 19:30:01 +0530 | From | sartgarg@codeauro ... | Subject | Re: [PATCH V1 1/7] dt-bindings: mmc: Add information for DLL register properties |
| |
On 2020-05-15 08:20, Rob Herring wrote: > On Thu, May 07, 2020 at 01:32:08PM +0530, Sarthak Garg wrote: >> Add information regarding DLL register properties for getting target >> specific configurations. These DLL register settings may vary from >> target to target. >> >> Also new compatible string value for sm8250 target. >> >> Signed-off-by: Sarthak Garg <sartgarg@codeaurora.org> >> --- >> Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 14 >> ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> index 5445931..b8e1d2b 100644 >> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> @@ -17,6 +17,7 @@ Required properties: >> "qcom,msm8916-sdhci", "qcom,sdhci-msm-v4" >> "qcom,msm8992-sdhci", "qcom,sdhci-msm-v4" >> "qcom,msm8996-sdhci", "qcom,sdhci-msm-v4" >> + "qcom,sm8250-sdhci", "qcom,sdhci-msm-v5" >> "qcom,sdm845-sdhci", "qcom,sdhci-msm-v5" >> "qcom,qcs404-sdhci", "qcom,sdhci-msm-v5" >> "qcom,sc7180-sdhci", "qcom,sdhci-msm-v5"; >> @@ -46,6 +47,13 @@ Required properties: >> "cal" - reference clock for RCLK delay calibration (optional) >> "sleep" - sleep clock for RCLK delay calibration (optional) >> >> +- qcom,ddr-config: Certain chipsets and platforms require particular >> settings >> + for the DDR_CONFIG register. Use this field to specify the register >> + value as per the Hardware Programming Guide. >> + >> +- qcom,dll-config: Chipset and Platform specific value. Use this >> field to >> + specify the DLL_CONFIG register value as per Hardware Programming >> Guide. > > Board specific or SoC specific? If the latter, imply this from the > compatible string.
Reposting again as can't find my comment on the https://patchwork.kernel.org/ page. Whatever DLL settings are SOC specific are being taken care with the compatible string. That is the reason we introduced qcom,sm8250-sdhci string. The above listed two configuration can change from board to board as-well.
| |