Messages in this thread | | | From | Baolin Wang <> | Date | Tue, 19 May 2020 21:13:01 +0800 | Subject | Re: [PATCH 2/2] clk: sprd: return correct type of value for _sprd_pll_recalc_rate |
| |
On Tue, May 19, 2020 at 11:00 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > The function _sprd_pll_recalc_rate() defines return value to unsigned > long, but it would return a negative value when malloc fail, changing > to return its parent_rate makes more sense, since if the callback > .recalc_rate() is not set, the framework returns the parent_rate as > well. > > Fixes: 3e37b005580b ("clk: sprd: add adjustable pll support") > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
Looks good to me. Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
-- Baolin Wang
| |