Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 19 May 2020 11:28:21 +0300 | Subject | Re: [PATCH V5 4/4] x86/resctrl: Use appropriate API for strings terminated by newline |
| |
On Tue, May 19, 2020 at 2:50 AM Reinette Chatre <reinette.chatre@intel.com> wrote:
...
> + ret = sysfs_match_string(rdt_mode_str, buf); > + if (ret < 0) { > + rdt_last_cmd_puts("Unknown or unsupported mode\n"); > + ret = -EINVAL; > + goto out; > + } > + > + user_m = ret;
> + } else if (user_m == RDT_MODE_PSEUDO_LOCKED) { > rdt_last_cmd_puts("Unknown or unsupported mode\n"); > ret = -EINVAL; > + goto out; > }
Can't we unify latter with a former like
if (ret == RDT_MODE_PSEUDO_LOCKED) ret = -EINVAL; if (ret < 0) { rdt_last_cmd_puts("Unknown or unsupported mode\n"); goto out; }
?
Or closer to initial like
if (ret < 0 || ret == RDT_MODE_PSEUDO_LOCKED) { rdt_last_cmd_puts("Unknown or unsupported mode\n"); ret = -EINVAL; goto out; }
-- With Best Regards, Andy Shevchenko
| |