Messages in this thread | | | Subject | Re: [PATCH] ath11k: Fix some resource leaks in error path in 'ath11k_thermal_register()' | From | Kalle Valo <> | Date | Tue, 19 May 2020 06:56:00 +0000 (UTC) |
| |
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> If 'thermal_cooling_device_register()' fails, we must undo what has been > allocated so far. So we must go to 'err_thermal_destroy' instead of > returning directly > > In case of error in 'ath11k_thermal_register()', the previous > 'thermal_cooling_device_register()' call must also be undone. Move the > 'ar->thermal.cdev = cdev' a few lines above in order for this to be done > in 'ath11k_thermal_unregister()' which is called in the error handling > path. > > Fixes: 2a63bbca06b2 ("ath11k: add thermal cooling device support") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
25ca180ad380 ath11k: Fix some resource leaks in error path in 'ath11k_thermal_register()'
-- https://patchwork.kernel.org/patch/11547195/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |