Messages in this thread | | | From | (Eric W. Biederman) | Date | Tue, 19 May 2020 15:20:27 -0500 | Subject | Re: [PATCH v2 7/8] exec: Generic execfd support |
| |
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Tue, May 19, 2020 at 12:46 PM Kees Cook <keescook@chromium.org> wrote: >> >> Though frankly, I wonder if interp_flags could just be removed in favor >> of two new bit members, especially since interp_data is gone: > > Yeah, I think that might be a good cleanup - but please keep it as a > separate thing at the end of the series (or maybe the beginning)
I will.
With a little care we can replace setting BINPRM_FLAGS_ENFORCE_NONDUMP and clearing bprm->mm->dumpable.
Which is the direction I have been looking.
Now that I think about it I believe that the loop in exec_binprm should be clearing BINPRM_FLAGS_PATH_INACCESSIBLE as it is only relevant to fexec/execveat with a close on exec file descriptor.
Eric
| |