lkml.org 
[lkml]   [2020]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [patch V6 15/37] x86/entry: Change exit path of xen_failsafe_callback
On Fri, May 15, 2020 at 5:10 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
>
> xen_failsafe_callback is invoked from XEN for two cases:
>
> 1. Fault while reloading DS, ES, FS or GS
> 2. Fault while executing IRET
>
> #1 retries the IRET after XEN has fixed up the segments.
> #2 injects a #GP which kills the task
>
> For #1 there is no reason to go through the full exception return path
> because the tasks TIF state is still the same. So just going straight to
> the IRET path is good enough.

Seems reasonable:

Acked-by: Andy Lutomirski <luto@kernel.org>

Although a look from a Xen person might be nice too.

\
 
 \ /
  Last update: 2020-05-19 22:15    [W:0.557 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site