lkml.org 
[lkml]   [2020]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 033/114] x86/unwind/orc: Fix error path for bad ORC entry type
    Date
    From: Josh Poimboeuf <jpoimboe@redhat.com>

    commit a0f81bf26888048100bf017fadf438a5bdffa8d8 upstream.

    If the ORC entry type is unknown, nothing else can be done other than
    reporting an error. Exit the function instead of breaking out of the
    switch statement.

    Fixes: ee9f8fce9964 ("x86/unwind: Add the ORC unwinder")
    Reviewed-by: Miroslav Benes <mbenes@suse.cz>
    Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Dave Jones <dsj@fb.com>
    Cc: Jann Horn <jannh@google.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Vince Weaver <vincent.weaver@maine.edu>
    Link: https://lore.kernel.org/r/a7fa668ca6eabbe81ab18b2424f15adbbfdc810a.1587808742.git.jpoimboe@redhat.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/x86/kernel/unwind_orc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/kernel/unwind_orc.c
    +++ b/arch/x86/kernel/unwind_orc.c
    @@ -457,7 +457,7 @@ bool unwind_next_frame(struct unwind_sta
    default:
    orc_warn("unknown .orc_unwind entry type %d for ip %pB\n",
    orc->type, (void *)orig_ip);
    - break;
    + goto done;
    }

    /* Find BP: */

    \
     
     \ /
      Last update: 2020-05-18 19:47    [W:4.045 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site