Messages in this thread | | | Date | Mon, 18 May 2020 10:18:02 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH 5/9] sit: refactor ipip6_tunnel_ioctl |
| |
On Mon, 18 May 2020 18:47:25 +0200 Christoph Hellwig wrote: > On Mon, May 18, 2020 at 09:43:56AM -0700, Jakub Kicinski wrote: > > On Mon, 18 May 2020 13:46:51 +0200 Christoph Hellwig wrote: > > > Split the ioctl handler into one function per command instead of having > > > a all the logic sit in one giant switch statement. > > > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > > > net/ipv6/sit.c: In function ipip6_tunnel_prl_ctl: > > net/ipv6/sit.c:460:6: warning: variable err set but not used [-Wunused-but-set-variable] > > 460 | int err; > > The warning looks correct, although my compiler doesn't report it :(
W=1, sorry, should've mentioned that!
| |