lkml.org 
[lkml]   [2020]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] proc: proc_pid_ns takes super_block as an argument
Alexey Gladkov <gladkov.alexey@gmail.com> writes:

> On Mon, May 18, 2020 at 07:08:57AM -0500, Eric W. Biederman wrote:
>> Alexey Gladkov <gladkov.alexey@gmail.com> writes:
>>
>> > The proc_pid_ns() can be used for both inode and dentry. To avoid making
>> > two identical functions, change the argument type of the proc_pid_ns().
>> >
>> > Link: https://lore.kernel.org/lkml/c3461e26-1407-2262-c709-dac0df3da2d0@i-love.sakura.ne.jp/
>> > Reported-by: syzbot+c1af344512918c61362c@syzkaller.appspotmail.com
>> > Signed-off-by: Alexey Gladkov <gladkov.alexey@gmail.com>
>>
>> So overall this looks good.
>>
>> However, the description leaves a little bit to be desired as it does
>> not describe why it is bad to use dentry->d_sb. A fixes tag would be
>> nice if for no other reason than to help anyone who decides to backport
>> this.
>
> OK. I will add it.

Thank you. It really helps to have the full description of why in
the commit comments.

>> And can you please compile test this?
>>
>> There is a very silly typo in proc that keeps this from compiling.
>
> I compiled the kernel with this patch and ran the kernel, but accidentally
> did not check children_seq_show(). Sorry.

Yes, children_seq_show is behind a sneaky CONFIG option.

Eric

\
 
 \ /
  Last update: 2020-05-18 15:01    [W:0.044 / U:1.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site