lkml.org 
[lkml]   [2020]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node
    Hi Prabhakar,

    On Fri, May 15, 2020 at 5:10 PM Lad Prabhakar
    <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
    > Add a device node for the Watchdog Timer (RWDT) controller on the Renesas
    > RZ/G1H (r8a7742) SoC.
    >
    > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>

    Thanks for your patch!

    > --- a/arch/arm/boot/dts/r8a7742.dtsi
    > +++ b/arch/arm/boot/dts/r8a7742.dtsi
    > @@ -201,6 +201,16 @@
    > #size-cells = <2>;
    > ranges;
    >
    > + rwdt: watchdog@e6020000 {
    > + compatible = "renesas,r8a7742-wdt",
    > + "renesas,rcar-gen2-wdt";
    > + reg = <0 0xe6020000 0 0x0c>;
    > + clocks = <&cpg CPG_MOD 402>;
    > + power-domains = <&sysc R8A7742_PD_ALWAYS_ON>;
    > + resets = <&cpg 402>;
    > + status = "disabled";

    Missing "interrupts" property.

    > + };
    > +
    > gpio0: gpio@e6050000 {
    > compatible = "renesas,gpio-r8a7742",
    > "renesas,rcar-gen2-gpio";

    The rest looks fine, so with the above fixed:
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2020-05-18 13:48    [W:4.528 / U:0.576 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site