lkml.org 
[lkml]   [2020]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] blkcg: Fix memory leak in blkg_conf_prep()
From
Date
On 2020/5/15 23:08, Markus Elfring wrote:
> …
>> new_blkg = blkg_alloc(pos, q, GFP_KERNEL);
> …
>
> I suggest to omit the source code quotation from the change description.
>
>
>> if calling blkg_lookup_check() failed, at the IS_ERR block,
>> the new_blkg should be free before goto lable fail_unlock
>> in blkg_conf_prep() function.
>
> How do you think about a wording variant like the following?
>
> If a call of the function “blkg_lookup_check” failed,
> release the previously allocated block group before jumping
> to the target “fail_unlock” in the implementation of
> the function “blkg_conf_prep”.
>

Thanks for your suggestion. omit the source code quotation from the
description is more friendly. I will modify the description in V2 patch.

Thanks,
Wu Bo

>
> Would you like to add the tag “Fixes” to the commit message?
>
> Regards,
> Markus
>


\
 
 \ /
  Last update: 2020-05-18 13:35    [W:0.039 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site