Messages in this thread | | | From | Ulf Hansson <> | Date | Mon, 18 May 2020 13:23:24 +0200 | Subject | Re: [PATCH 2/2] mmc: host: meson-mx-sdhc: don't use literal 0 to initialize structs |
| |
On Mon, 18 May 2020 at 00:29, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > Kbuild test robot reports the following warning in lines 56 and 87 of > drivers/mmc/host/meson-mx-sdhc-clkc.c: > Using plain integer as NULL pointer > > Drop the integer value from the struct initialization to fix that > warning. This will still ensure that the compiler will zero out the > struct so it's in a well-defined state. > > Fixes: 53ded1b676d199 ("mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host") > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Applied for next, thanks!
Kind regards Uffe
> --- > drivers/mmc/host/meson-mx-sdhc-clkc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/meson-mx-sdhc-clkc.c b/drivers/mmc/host/meson-mx-sdhc-clkc.c > index ab0d6c68a078..e1f29b279123 100644 > --- a/drivers/mmc/host/meson-mx-sdhc-clkc.c > +++ b/drivers/mmc/host/meson-mx-sdhc-clkc.c > @@ -53,7 +53,7 @@ static int meson_mx_sdhc_clk_hw_register(struct device *dev, > const struct clk_ops *ops, > struct clk_hw *hw) > { > - struct clk_init_data init = { 0 }; > + struct clk_init_data init = { }; > char clk_name[32]; > > snprintf(clk_name, sizeof(clk_name), "%s#%s", dev_name(dev), > @@ -84,7 +84,7 @@ static int meson_mx_sdhc_gate_clk_hw_register(struct device *dev, > int meson_mx_sdhc_register_clkc(struct device *dev, void __iomem *base, > struct clk_bulk_data *clk_bulk_data) > { > - struct clk_parent_data div_parent = { 0 }; > + struct clk_parent_data div_parent = { }; > struct meson_mx_sdhc_clkc *clkc_data; > int ret; > > -- > 2.26.2 >
| |