Messages in this thread | | | Date | Mon, 18 May 2020 11:34:02 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 3/3] perf/x86/rapl: add AMD Fam17h RAPL support |
| |
On Fri, May 15, 2020 at 02:57:33PM -0700, Stephane Eranian wrote:
> +static struct perf_msr amd_rapl_msrs[] = { > + [PERF_RAPL_PP0] = { 0, &rapl_events_cores_group, NULL}, > + [PERF_RAPL_PKG] = { MSR_AMD_PKG_ENERGY_STATUS, &rapl_events_pkg_group, test_msr }, > + [PERF_RAPL_RAM] = { 0, &rapl_events_ram_group, NULL}, > + [PERF_RAPL_PP1] = { 0, &rapl_events_gpu_group, NULL}, > + [PERF_RAPL_PSYS] = { 0, &rapl_events_psys_group, NULL}, > +};
Why have those !PKG things initialized? Wouldn't they default to 0 anyway? If not, surely { 0, } is sufficient.
| |