Messages in this thread | | | From | Arnd Bergmann <> | Date | Mon, 18 May 2020 11:30:21 +0200 | Subject | Re: [PATCH v4 7/7] firmware: smccc: Add ARCH_SOC_ID support |
| |
On Mon, May 18, 2020 at 11:12 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
> +static ssize_t > +jep106_cont_bank_code_show(struct device *dev, struct device_attribute *attr, > + char *buf) > +{ > + return sprintf(buf, "0x%02x\n", JEP106_BANK_CONT_CODE(soc_id_version)); > +} > + > +static DEVICE_ATTR_RO(jep106_cont_bank_code); > + > +static ssize_t > +jep106_identification_code_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + return sprintf(buf, "0x%02x\n", JEP106_ID_CODE(soc_id_version)); > +}
I think we should try hard to avoid nonstandard attributes for the soc device.
Did you run into a problem with finding one of the existing attributes that can be used to hold the fields?
Arnd
| |