lkml.org 
[lkml]   [2020]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1 2/3] mmc: sdhci-msm: Use internal voltage control
On Mon 18 May 12:57 PDT 2020, Bjorn Andersson wrote:
> On Fri 15 May 04:18 PDT 2020, Veerabhadrarao Badiganti wrote:
> > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
[..]
> > +static int sdhci_msm_register_vreg(struct sdhci_msm_host *msm_host)
> > +{
> > + int ret = 0;
>
> No need to initialize ret, first use is an assignment.
>
> > + struct mmc_host *mmc = msm_host->mmc;
> > +
> > + ret = mmc_regulator_get_supply(msm_host->mmc);
> > + if (ret)
> > + return ret;
> > + device_property_read_u32(&msm_host->pdev->dev,
> > + "vmmc-max-load-microamp",
> > + &msm_host->vmmc_load);
> > + device_property_read_u32(&msm_host->pdev->dev,
> > + "vqmmc-max-load-microamp",
> > + &msm_host->vqmmc_load);
>
> These properties are not documented. Do they vary enough to mandate
> being read from DT or could they simply be approximated by a define
> instead?
>

Disregard my comment about them not being documented, I wasn't Cc'ed on
the binding patch and missed it.

My question about just defining them statically still stands.

Thanks,
Bjorn

\
 
 \ /
  Last update: 2020-05-19 05:13    [W:0.084 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site