Messages in this thread | | | Date | Mon, 18 May 2020 09:14:30 +0100 | From | Marc Zyngier <> | Subject | Re: [PATCH 3/4] irqchip/sifive-plic: Separate irq_chip for muiltiple PLIC instances |
| |
On 2020-05-16 17:38, Anup Patel wrote: >> -----Original Message----- >> From: Marc Zyngier <maz@kernel.org>
[...]
>> I *have* given you a way to implement that in a better way. But again, >> I'd >> rather you *don't* do it for the reason I have outlined above. > > I explored kernel/irq/proc.c and we can achieve what this patch does > by implementing irq_print_chip() callback of "struct irq_chip" so we > certainly don't need separate "struct irq_chip" for each PLIC instance. > > I will implement irq_print_chip() callback in v2 series.
You still haven't explained *why* you need to have this change. As it stands, I'm not prepared to take it.
Thanks,
M. -- Jazz is not dead. It just smells funny...
| |