lkml.org 
[lkml]   [2020]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] arm64/cpufeature: Drop open encodings while extracting parange
On Mon, 18 May 2020 18:09:34 +0100,
Will Deacon <will@kernel.org> wrote:
>
> On Mon, May 18, 2020 at 05:59:59PM +0100, Will Deacon wrote:
> > On Wed, May 13, 2020 at 02:33:34PM +0530, Anshuman Khandual wrote:
> > > Currently there are multiple instances of parange feature width mask open
> > > encodings while fetching it's value. Even the width mask value (0x7) itself
> > > is not accurate. It should be (0xf) per ID_AA64MMFR0_EL1.PARange[3:0] as in
> > > ARM ARM (0487F.a). Replace them with cpuid_feature_extract_unsigned_field()
> > > which can extract given standard feature (4 bits width i.e 0xf mask) field.
> > >
> > > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > > Cc: Will Deacon <will@kernel.org>
> > > Cc: Marc Zyngier <maz@kernel.org>
> > > Cc: James Morse <james.morse@arm.com>
> > > Cc: kvmarm@lists.cs.columbia.edu
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > Cc: linux-kernel@vger.kernel.org
> > >
> > > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> > > ---
> > > Changes in V2:
> > >
> > > - Used cpuid_feature_extract_unsigned_field() per Mark
> > >
> > > Changes in V1: (https://patchwork.kernel.org/patch/11541913/)
> > >
> > > arch/arm64/kernel/cpufeature.c | 3 ++-
> > > arch/arm64/kvm/reset.c | 11 ++++++++---
> > > 2 files changed, 10 insertions(+), 4 deletions(-)
> >
> > Acked-by: Will Deacon <will@kernel.org>
> >
> > I'm assuming Marc will take this, but let me know if it should go via arm64
> > instead (where we have a bunch of other cpufeature stuff queued).
>
> Hmm, but having just spotted [1], it looks like we might need a bit of
> co-ordination here. Marc?

Yeah, there is a clear dependency between the two. I'm happy to take
both patches via the KVM tree, or to have a shared branch with the
arm64 tree (we already have one for Andrew's generic AT patch).

Just let me know,

M.

--
Without deviation from the norm, progress is not possible.

\
 
 \ /
  Last update: 2020-05-18 20:48    [W:0.061 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site