lkml.org 
[lkml]   [2020]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 062/147] i40iw: Fix error handling in i40iw_manage_arp_cache()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 37e31d2d26a4124506c24e95434e9baf3405a23a ]

    The i40iw_arp_table() function can return -EOVERFLOW if
    i40iw_alloc_resource() fails so we can't just test for "== -1".

    Fixes: 4e9042e647ff ("i40iw: add hw and utils files")
    Link: https://lore.kernel.org/r/20200422092211.GA195357@mwanda
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/i40iw/i40iw_hw.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/infiniband/hw/i40iw/i40iw_hw.c b/drivers/infiniband/hw/i40iw/i40iw_hw.c
    index 55a1fbf0e670c..ae8b97c306657 100644
    --- a/drivers/infiniband/hw/i40iw/i40iw_hw.c
    +++ b/drivers/infiniband/hw/i40iw/i40iw_hw.c
    @@ -534,7 +534,7 @@ void i40iw_manage_arp_cache(struct i40iw_device *iwdev,
    int arp_index;

    arp_index = i40iw_arp_table(iwdev, ip_addr, ipv4, mac_addr, action);
    - if (arp_index == -1)
    + if (arp_index < 0)
    return;
    cqp_request = i40iw_get_cqp_request(&iwdev->cqp, false);
    if (!cqp_request)
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-05-18 19:57    [W:2.568 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site