lkml.org 
[lkml]   [2020]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] afs: Don't unlock fetched data pages until the op completes successfully
Date
Matthew Wilcox <willy@infradead.org> wrote:

> > + if (req->page_done)
> > + for (req->index = 0; req->index < req->nr_pages; req->index++)
> > + req->page_done(req);
> > +
>
> I'd suggest doing one call rather than N and putting the page iteration
> inside the callback. But this patch is appropriate for this late in
> the -rc series, just something to consider for the future.

My rewrite of the fscache stuff changes this bit of the code anyway, and makes
it one call which may start a write out to the cache.

David

\
 
 \ /
  Last update: 2020-05-18 00:37    [W:0.033 / U:0.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site