lkml.org 
[lkml]   [2020]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/4] ipv6: symbol_get to access a sit symbol
From
From: Christoph Hellwig <hch@lst.de>
Date: Fri, 15 May 2020 08:33:24 +0200

> My initial plan was to add a ->tunnel_ctl method to the net_device_ops,
> and lift the copy_{to,from}_user for SIOCADDTUNNEL, SIOCCHGTUNNEL,
> SIOCDELTUNNEL and maybe SIOCGETTUNNEL to net/socket.c. But that turned
> out to have two problems:
>
> - first these ioctls names use SIOCDEVPRIVATE range, that can also
> be implemented by other drivers
> - the ip_tunnel_parm struture is only used by the ipv4 tunneling
> drivers (including sit), the "real" ipv6 tunnels use a
> ip6_tnl_parm or ip6_tnl_parm structure instead

Yes, this is the core of the problem, the user provided data's type
is unknown until we are very deep in the call chains.

I wonder if there is some clever way to propagate this size value
"up"?

\
 
 \ /
  Last update: 2020-05-16 22:56    [W:0.046 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site