Messages in this thread | | | Date | Fri, 15 May 2020 16:55:38 +0200 | From | Matej Dujava <> | Subject | Re: [PATCH v3 2/2] staging: vt6655: vt6656: change order of makefile variable definitions |
| |
On Fri, May 15, 2020 at 03:48:59PM +0200, Greg Kroah-Hartman wrote: >I still fail to understand the need for this patch at all. It doesn't >clean anything up, nor change anything. There is no rule that this has >to be in one order or the other, and in fact, I like the order that the >files currently have :) > >thanks, > >greg k-h
Most of makefiles has pattern that `obj-${}` is before `driver-y` lines. If this is not something that was intentional, then this patch is not adding any value indeed.
Few examples that give me that impression:
./gnss/Makefile-# SPDX-License-Identifier: GPL-2.0 ./gnss/Makefile-# ./gnss/Makefile-# Makefile for the GNSS subsystem. ./gnss/Makefile-# ./gnss/Makefile- ./gnss/Makefile:obj-$(CONFIG_GNSS) += gnss.o ./gnss/Makefile-gnss-y := core.o ./gnss/Makefile- ./gnss/Makefile:obj-$(CONFIG_GNSS_SERIAL) += gnss-serial.o ./gnss/Makefile-gnss-serial-y := serial.o --snip end--
./.../go7007/Makefile-# SPDX-License-Identifier: GPL-2.0 ./.../go7007/Makefile:obj-$(CONFIG_VIDEO_GO7007) += go7007.o ./.../go7007/Makefile:obj-$(CONFIG_VIDEO_GO7007_USB) += go7007-usb.o ./.../go7007/Makefile:obj-$(CONFIG_VIDEO_GO7007_LOADER) += go7007-loader.o ./.../go7007/Makefile:obj-$(CONFIG_VIDEO_GO7007_USB_S2250_BOARD) += s2250.o ./.../go7007/Makefile- ./.../go7007/Makefile-go7007-y := go7007-v4l2.o go7007-driver.o go7007-i2c. ./.../go7007/Makefile- snd-go7007.o ./.../go7007/Makefile- ./.../go7007/Makefile-s2250-y := s2250-board.o --snip end--
Thanks, Matej
| |