lkml.org 
[lkml]   [2020]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] soc: mediatek: Missing platform_device_unregister() on error in mtk_mmsys_probe()
From
Date


On 06/05/2020 19:24, Enric Balletbo i Serra wrote:
> Hi Wei,
>
> Thank you for your patch.
>
> On 6/5/20 16:13, Wei Yongjun wrote:
>> Add the missing platform_device_unregister() before return
>> from mtk_mmsys_probe() in the error handling case.
>>
>> Fixes: 667c769246b0 ("soc / drm: mediatek: Fix mediatek-drm device probing")
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>

applied to v5.7-next/soc

Thanks!

>> ---
>> drivers/soc/mediatek/mtk-mmsys.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
>> index 05e322c9c301..05ce4cb464b0 100644
>> --- a/drivers/soc/mediatek/mtk-mmsys.c
>> +++ b/drivers/soc/mediatek/mtk-mmsys.c
>> @@ -312,8 +312,10 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
>>
>> drm = platform_device_register_data(&pdev->dev, "mediatek-drm",
>> PLATFORM_DEVID_AUTO, NULL, 0);
>> - if (IS_ERR(drm))
>> + if (IS_ERR(drm)) {
>> + platform_device_unregister(clks);
>> return PTR_ERR(drm);
>> + }
>>
>> return 0;
>> }
>>
>>
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>

\
 
 \ /
  Last update: 2020-05-15 16:52    [W:0.291 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site