lkml.org 
[lkml]   [2020]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] serdev: ttyport: add devt for tty port
On Wed, May 06, 2020 at 03:23:12PM +0800, Claire Chang wrote:
> serial_match_port() uses devt to match devices. However, when serdev
> registers a tty port, devt has never been set. This makes
> device_find_child() always return NULL.
>
> Assign devt in serdev_tty_port_register() to fix this.
>
> Signed-off-by: Claire Chang <tientzu@chromium.org>
> ---
> drivers/tty/serdev/serdev-ttyport.c | 2 ++
> 1 file changed, 2 insertions(+)

So is existing code broken because of this? Or does no one ever call
device_find_child() on this? Who needs/uses this?

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-05-15 14:47    [W:1.057 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site