Messages in this thread | | | Date | Fri, 15 May 2020 09:25:39 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v6 3/5] kernel/cpu_pm: Fix uninitted local in cpu_pm |
| |
On Mon, May 04, 2020 at 10:50:17AM -0700, Douglas Anderson wrote: > cpu_pm_notify() is basically a wrapper of notifier_call_chain(). > notifier_call_chain() doesn't initialize *nr_calls to 0 before it > starts incrementing it--presumably it's up to the callers to do this. > > Unfortunately the callers of cpu_pm_notify() don't init *nr_calls. > This potentially means you could get too many or two few calls to > CPU_PM_ENTER_FAILED or CPU_CLUSTER_PM_ENTER_FAILED depending on the > luck of the stack. > > Let's fix this. > > Fixes: ab10023e0088 ("cpu_pm: Add cpu power management notifiers") > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Douglas Anderson <dianders@chromium.org> > ---
Should also have a cc: stable@vger.kernel.org tag on it.
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| |