Messages in this thread | | | Date | Fri, 15 May 2020 20:44:20 +0000 | From | Luis Chamberlain <> | Subject | Re: [PATCH v5 2/7] firmware: add offset to request_firmware_into_buf |
| |
On Wed, May 13, 2020 at 11:35:06AM -0700, Scott Branden wrote: > On 2020-05-12 5:33 p.m., Luis Chamberlain wrote: > > On Thu, May 07, 2020 at 05:27:34PM -0700, Scott Branden wrote: > > flags? But its a single variable enum! > fw_opt is an existing enum which doesn't really act like an enum. > It is a series of BIT defines in an enum that are then OR'd together in the > (existing) code?
Indeed, in retrospect that is odd, it should be a u32 then. Please feel free to fix.
Luis
| |