lkml.org 
[lkml]   [2020]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 09/14] videobuf2: check ->synced flag in prepare() and finish()
    Date
    From: Sergey Senozhatsky <senozhatsky@chromium.org>

    This simplifies the code a tiny bit and let's us to avoid
    unneeded ->prepare()/->finish() calls.

    Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
    ---
    drivers/media/common/videobuf2/videobuf2-core.c | 9 +++++++--
    1 file changed, 7 insertions(+), 2 deletions(-)

    diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
    index 1a55ea19160b..7e081716b8da 100644
    --- a/drivers/media/common/videobuf2/videobuf2-core.c
    +++ b/drivers/media/common/videobuf2/videobuf2-core.c
    @@ -304,6 +304,9 @@ static void __vb2_buf_mem_prepare(struct vb2_buffer *vb)
    {
    unsigned int plane;

    + if (vb->synced)
    + return;
    +
    if (vb->need_cache_sync_on_prepare) {
    for (plane = 0; plane < vb->num_planes; ++plane)
    call_void_memop(vb, prepare,
    @@ -320,6 +323,9 @@ static void __vb2_buf_mem_finish(struct vb2_buffer *vb)
    {
    unsigned int plane;

    + if (!vb->synced)
    + return;
    +
    if (vb->need_cache_sync_on_finish) {
    for (plane = 0; plane < vb->num_planes; ++plane)
    call_void_memop(vb, finish,
    @@ -2000,8 +2006,7 @@ static void __vb2_queue_cancel(struct vb2_queue *q)
    call_void_vb_qop(vb, buf_request_complete, vb);
    }

    - if (vb->synced)
    - __vb2_buf_mem_finish(vb);
    + __vb2_buf_mem_finish(vb);

    if (vb->prepared) {
    call_void_vb_qop(vb, buf_finish, vb);
    --
    2.26.2
    \
     
     \ /
      Last update: 2020-05-14 18:03    [W:2.389 / U:1.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site