lkml.org 
[lkml]   [2020]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: is it ok to always pull in sctp for dlm, was: Re: [PATCH 27/33] sctp: export sctp_setsockopt_bindx
    On Thu, May 14, 2020 at 12:40:40PM +0200, Christoph Hellwig wrote:
    > On Wed, May 13, 2020 at 03:00:58PM -0300, Marcelo Ricardo Leitner wrote:
    > > On Wed, May 13, 2020 at 08:26:42AM +0200, Christoph Hellwig wrote:
    > > > And call it directly from dlm instead of going through kernel_setsockopt.
    > >
    > > The advantage on using kernel_setsockopt here is that sctp module will
    > > only be loaded if dlm actually creates a SCTP socket. With this
    > > change, sctp will be loaded on setups that may not be actually using
    > > it. It's a quite big module and might expose the system.
    > >
    > > I'm okay with the SCTP changes, but I'll defer to DLM folks to whether
    > > that's too bad or what for DLM.
    >
    > So for ipv6 I could just move the helpers inline as they were trivial
    > and avoid that issue. But some of the sctp stuff really is way too
    > big for that, so the only other option would be to use symbol_get.

    Let's try symbol_get, having the sctp module always loaded caused problems
    last time it happened (almost nobody uses dlm with it.)
    Dave

    \
     
     \ /
      Last update: 2020-05-14 16:25    [W:4.186 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site