Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 14 May 2020 16:12:10 +0200 | Subject | Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: Add sm8250 pinctrl bindings |
| |
On Thu, May 14, 2020 at 8:04 AM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > On Wed 29 Apr 14:34 PDT 2020, Rob Herring wrote: > > On Thu, Apr 16, 2020 at 11:19:06PM -0700, Bjorn Andersson wrote: > > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml > [..] > > > +#PIN CONFIGURATION NODES > > > +patternProperties: > > > + '^.*$': > > > + if: > > > + type: object > > > + then: > > > > Needs a $ref to the standard properties. > > > > Would be good to show a child node in the example too. (And try having > > an error in a standard property type to verify you get an error). > > > > Finally looked into this.
Can you send an incremental patch because otherwise I have to revert the patch that I merged (maybe to trigger happy, mea culpa).
(If it's too hard I can just revert it.)
Yours, Linus Walleij
| |