lkml.org 
[lkml]   [2020]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 04/12] remoteproc: stm32: Remove memory translation from DT parsing
    On Fri 24 Apr 13:24 PDT 2020, Mathieu Poirier wrote:

    > Other than one has to be done after the other, there is no correlation
    > between memory translation and DT parsing. As move function
    > stm32_rproc_of_memory_translations() to stm32_rproc_probe() so that
    > stm32_rproc_parse_dt() can be extended to look for synchronisation
    > related binding in a clean way.
    >
    > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    > Reviewed-by: Loic Pallardy <loic.pallardy@st.com>

    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

    > ---
    > drivers/remoteproc/stm32_rproc.c | 6 +++++-
    > 1 file changed, 5 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
    > index 57a426ea620b..658439d4b00a 100644
    > --- a/drivers/remoteproc/stm32_rproc.c
    > +++ b/drivers/remoteproc/stm32_rproc.c
    > @@ -606,7 +606,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
    >
    > *auto_boot = of_property_read_bool(np, "st,auto-boot");
    >
    > - return stm32_rproc_of_memory_translations(pdev, ddata);
    > + return 0;
    > }
    >
    > static int stm32_rproc_probe(struct platform_device *pdev)
    > @@ -634,6 +634,10 @@ static int stm32_rproc_probe(struct platform_device *pdev)
    > if (ret)
    > goto free_rproc;
    >
    > + ret = stm32_rproc_of_memory_translations(pdev, ddata);
    > + if (ret)
    > + goto free_rproc;
    > +
    > rproc->auto_boot = auto_boot;
    > rproc->has_iommu = false;
    > ddata->workqueue = create_workqueue(dev_name(dev));
    > --
    > 2.20.1
    >

    \
     
     \ /
      Last update: 2020-05-14 07:05    [W:3.287 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site