lkml.org 
[lkml]   [2020]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 20/33] ipv4: add ip_sock_set_recverr
From
Date
On Thu, 2020-05-14 at 12:30 +0200, Christoph Hellwig wrote:
> On Wed, May 13, 2020 at 02:00:43PM -0700, Joe Perches wrote:
> > On Wed, 2020-05-13 at 08:26 +0200, Christoph Hellwig wrote:
> > > Add a helper to directly set the IP_RECVERR sockopt from kernel space
> > > without going through a fake uaccess.
> >
> > This seems used only with true as the second arg.
> > Is there reason to have that argument at all?
>
> Mostly to keep it symmetric with the sockopt. I could probably remove
> a few arguments in the series if we want to be strict.

My preference would use strict and add
arguments only when necessary.


\
 
 \ /
  Last update: 2020-05-14 13:52    [W:0.097 / U:1.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site