lkml.org 
[lkml]   [2020]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [v2 4/4] regulator: qcom: labibb: Add SC interrupt handling
    Hello Mark,

    Thanks for the review comments.

    On Mon, 11 May 2020 at 16:19, Mark Brown <broonie@kernel.org> wrote:
    >
    > On Sat, May 09, 2020 at 02:12:00AM +0530, Sumit Semwal wrote:
    >
    > > +static irqreturn_t labibb_sc_err_handler(int irq, void *_reg)
    > > +{
    > > + int ret, count;
    > > + u16 reg;
    > > + u8 sc_err_mask;
    > > + unsigned int val;
    > > + struct labibb_regulator *labibb_reg = (struct labibb_regulator *)_reg;
    > > + bool in_sc_err, reg_en, scp_done = false;
    > > +
    > > + if (irq == labibb_reg->sc_irq)
    > > + reg = labibb_reg->base + REG_LABIBB_STATUS1;
    > > + else
    > > + return IRQ_HANDLED;
    >
    > Why would we be registering the interrupt handler when it's not valid?
    Agreed, will correct.

    Best,
    Sumit.

    \
     
     \ /
      Last update: 2020-05-14 13:51    [W:3.504 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site