Messages in this thread Patch in this message | | | From | Ravi Bangoria <> | Subject | [PATCH v6 15/16] powerpc/watchpoint/xmon: Don't allow breakpoint overwriting | Date | Thu, 14 May 2020 16:47:40 +0530 |
| |
Xmon allows overwriting breakpoints because it's supported by only one DAWR. But with multiple DAWRs, overwriting becomes ambiguous or unnecessary complicated. So let's not allow it.
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> Reviewed-by: Michael Neuling <mikey@neuling.org> --- arch/powerpc/xmon/xmon.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index 30b3e3d99c0d..094bf4715f2c 100644 --- a/arch/powerpc/xmon/xmon.c +++ b/arch/powerpc/xmon/xmon.c @@ -1399,6 +1399,10 @@ bpt_cmds(void) printf("Hardware data breakpoint not supported on this cpu\n"); break; } + if (dabr.enabled) { + printf("Couldn't find free breakpoint register\n"); + break; + } mode = 7; cmd = inchar(); if (cmd == 'r') -- 2.26.2
| |