Messages in this thread | | | Subject | Re: [PATCH 00/19 V2] mm: memcontrol: charge swapin pages on instantiation | From | Balbir Singh <> | Date | Thu, 14 May 2020 21:04:53 +1000 |
| |
On 13/5/20 10:35 pm, Johannes Weiner wrote: > As a result, the memcg gets a breakdown for memory.stat without having > to have private knowledge of what a page cache page is - how to test > it, when it's safe to test it, whether there can be huge pages in the > page cache, etc. pp. Memcg can focus on counting bytes, and the VM > code that is specialized in dealing with the page cache (or anon > pages, or shmem pages) can fill in those kinds of details for us. > > Less dependencies, less duplication, simpler API rules. > > The memory.stat output is the same, it's just much simpler code.
Makes sense! Thanks, I should spend some time to re-read all of the memcontrol.c code :)
Balbir Singh.
| |