Messages in this thread | | | Date | Thu, 14 May 2020 13:30:42 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v7 2/3] drivers: input: keyboard: Add mtk keypad driver |
| |
On Thu, May 14, 2020 at 01:27:01PM +0300, Andy Shevchenko wrote: > On Thu, May 14, 2020 at 02:17:48PM +0800, Fengping Yu wrote: > > From: "fengping.yu" <fengping.yu@mediatek.com> > > > > This adds matrix keypad support for Mediatek SoCs. > > ... > > > +config KEYBOARD_MTK_KPD > > + tristate "MediaTek Keypad Support" > > > + depends on OF && HAVE_CLK > > What makes it OF dependent?
Actually you missed regmap dependencies or selection. I dunno which one should be used (IIRC selection).
> > + help > > + Say Y here if you want to use the keypad on MediaTek SoCs. > > + If unsure, say N. > > + To compile this driver as a module, choose M here: the > > + module will be called mtk-kpd.
-- With Best Regards, Andy Shevchenko
| |