lkml.org 
[lkml]   [2020]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 2/3] drivers: input: keyboard: Add mtk keypad driver
    On Thu, May 14, 2020 at 01:27:01PM +0300, Andy Shevchenko wrote:
    > On Thu, May 14, 2020 at 02:17:48PM +0800, Fengping Yu wrote:
    > > From: "fengping.yu" <fengping.yu@mediatek.com>
    > >
    > > This adds matrix keypad support for Mediatek SoCs.
    >
    > ...
    >
    > > +config KEYBOARD_MTK_KPD
    > > + tristate "MediaTek Keypad Support"
    >
    > > + depends on OF && HAVE_CLK
    >
    > What makes it OF dependent?

    Actually you missed regmap dependencies or selection. I dunno which one should
    be used (IIRC selection).

    > > + help
    > > + Say Y here if you want to use the keypad on MediaTek SoCs.
    > > + If unsure, say N.
    > > + To compile this driver as a module, choose M here: the
    > > + module will be called mtk-kpd.


    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2020-05-14 12:31    [W:2.725 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site