lkml.org 
[lkml]   [2020]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver
On Wed, May 13, 2020 at 07:58:12PM +0800, Tzung-Bi Shih wrote:
> On Wed, May 13, 2020 at 6:53 PM Mark Brown <broonie@kernel.org> wrote:
> > On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote:

> > > Changes since V2:
> > > * Removed warn massage in max98390_dsm_calib_get func
> > > and add comment.

> > The problem isn't the warning, the problem is that you have an empty
> > operation. You should either implement the function (eg, by caching the
> > value written) or remove it and fix whatever problems you were running
> > into further up the stack when it's missing.

> The purpose for the mixer control is: to signal max98390 to start to
> calibrate from userspace.
> Thus,
> max98390_dsm_calib_get() -> do nothing.
> max98390_dsm_calib_put() -> call max98390_dsm_calibrate().

In that case it should probably do something like read back if a
callibration is currently running.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-05-14 12:18    [W:0.051 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site