Messages in this thread | | | Subject | Re: [PATCH v13 4/8] iommu/vt-d: Add bind guest PASID support | From | Lu Baolu <> | Date | Fri, 15 May 2020 09:01:33 +0800 |
| |
Hi Jacob,
On 5/14/20 11:57 PM, Jacob Pan wrote: >>> + /* >>> + * PASID table is per device for better security. >>> Therefore, for >>> + * each bind of a new device even with an existing PASID, >>> we need to >>> + * call the nested mode setup function here. >>> + */ >>> + spin_lock(&iommu->lock); >>> + ret = intel_pasid_setup_nested(iommu, >>> + dev, >>> + (pgd_t *)data->gpgd, >>> + data->hpasid, >>> + &data->vtd, >>> + dmar_domain, >>> + data->addr_width); >> Why not: >> >> et = intel_pasid_setup_nested(iommu, dev, (pgd_t *)data->gpgd, >> data->hpasid, &data->vtd, dmar_domain, >> data->addr_width); >> >> ? >> > I thought we want to align the parentheses? Either way is fine. > Baolu? >
Let's keep the code style consistent in this file.
Best regards, baolu
| |