lkml.org 
[lkml]   [2020]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 8/9] fs/ext4: Introduce DAX inode flag
    On Thu, May 14, 2020 at 08:43:35AM +0200, Jan Kara wrote:
    > On Wed 13-05-20 14:41:55, Ira Weiny wrote:
    > > On Wed, May 13, 2020 at 04:47:06PM +0200, Jan Kara wrote:
    > > >
    > > > So I think you'll have to check
    > > > whether DAX flag is being changed,
    > >
    > > ext4_dax_dontcache() does check if the flag is being changed.
    >
    > Yes, but if you call it after inode flags change, you cannot determine that
    > just from flags and EXT4_I(inode)->i_flags. So that logic needs to change.

    I just caught this email... just after sending V1.

    I've moved where ext4_dax_dontcache() is called. I think it is ok now with the
    current check.

    LMK if I've messed it up... :-/

    Ira

    >
    > Honza
    >
    > --
    > Jan Kara <jack@suse.com>
    > SUSE Labs, CR

    \
     
     \ /
      Last update: 2020-05-14 08:56    [W:3.494 / U:0.636 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site