Messages in this thread | | | Date | Thu, 14 May 2020 09:54:15 +0300 | From | Heikki Krogerus <> | Subject | Re: [PATCH] kobject: Make sure the parent does not get released before its children |
| |
On Wed, May 13, 2020 at 04:14:51PM -0700, Randy Dunlap wrote: > On 5/13/20 2:30 PM, Brendan Higgins wrote: > > On Wed, May 13, 2020 at 8:18 AM Heikki Krogerus > > <heikki.krogerus@linux.intel.com> wrote: > >> > >> In the function kobject_cleanup(), kobject_del(kobj) is > >> called before the kobj->release(). That makes it possible to > >> release the parent of the kobject before the kobject itself. > >> > >> To fix that, adding function __kboject_del() that does > >> everything that kobject_del() does except release the parent > >> reference. kobject_cleanup() then calls __kobject_del() > >> instead of kobject_del(), and separately decrements the > >> reference count of the parent kobject after kobj->release() > >> has been called. > >> > >> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > >> Reported-by: kernel test robot <rong.a.chen@intel.com> > >> Fixes: 7589238a8cf3 ("Revert "software node: Simplify software_node_release() function"") > >> Cc: Brendan Higgins <brendanhiggins@google.com> > >> Cc: Randy Dunlap <rdunlap@infradead.org> > >> Suggested-by: "Rafael J. Wysocki" <rafael@kernel.org> > >> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > > > Reviewed-by: Brendan Higgins <brendanhiggins@google.com> > > Tested-by: Brendan Higgins <brendanhiggins@google.com> > > > > Acked-by: Randy Dunlap <rdunlap@infradead.org> > Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks guys. Sorry about the mix-up.
Br,
-- heikki
| |