lkml.org 
[lkml]   [2020]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 10/31] vhost/vsock: fix packet delivery order to monitoring devices
    Date
    From: Stefano Garzarella <sgarzare@redhat.com>

    [ Upstream commit 107bc0766b9feb5113074c753735a3f115c2141f ]

    We want to deliver packets to monitoring devices before it is
    put in the virtqueue, to avoid that replies can appear in the
    packet capture before the transmitted packet.

    Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/vhost/vsock.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
    index bac1365cc81b5..7891bd40ebd82 100644
    --- a/drivers/vhost/vsock.c
    +++ b/drivers/vhost/vsock.c
    @@ -182,14 +182,14 @@ vhost_transport_do_send_pkt(struct vhost_vsock *vsock,
    break;
    }

    - vhost_add_used(vq, head, sizeof(pkt->hdr) + payload_len);
    - added = true;
    -
    - /* Deliver to monitoring devices all correctly transmitted
    - * packets.
    + /* Deliver to monitoring devices all packets that we
    + * will transmit.
    */
    virtio_transport_deliver_tap_pkt(pkt);

    + vhost_add_used(vq, head, sizeof(pkt->hdr) + payload_len);
    + added = true;
    +
    pkt->off += payload_len;
    total_len += payload_len;

    --
    2.20.1
    \
     
     \ /
      Last update: 2020-05-14 21:05    [W:3.113 / U:1.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site