Messages in this thread | | | Date | Thu, 14 May 2020 08:28:20 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 27/33] sctp: export sctp_setsockopt_bindx |
| |
On Wed, May 13, 2020 at 03:00:58PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, May 13, 2020 at 08:26:42AM +0200, Christoph Hellwig wrote: > > And call it directly from dlm instead of going through kernel_setsockopt. > > The advantage on using kernel_setsockopt here is that sctp module will > only be loaded if dlm actually creates a SCTP socket. With this > change, sctp will be loaded on setups that may not be actually using > it. It's a quite big module and might expose the system.
True. Not that the intent is to kill kernel space callers of setsockopt, as I plan to remove the set_fs address space override used for it. So if always pulling in sctp is not an option for the DLM maintainers we'd have to do tricks using symbol_get() or similar.
The same would also apply for ipv6, although I'm not sure how common modular ipv6 is in practice.
| |