lkml.org 
[lkml]   [2020]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 105/118] KVM: x86: Fixes posted interrupt check for IRQs delivery modes
    Date
    From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>

    commit 637543a8d61c6afe4e9be64bfb43c78701a83375 upstream.

    Current logic incorrectly uses the enum ioapic_irq_destination_types
    to check the posted interrupt destination types. However, the value was
    set using APIC_DM_XXX macros, which are left-shifted by 8 bits.

    Fixes by using the APIC_DM_FIXED and APIC_DM_LOWEST instead.

    Fixes: (fdcf75621375 'KVM: x86: Disable posted interrupts for non-standard IRQs delivery modes')
    Cc: Alexander Graf <graf@amazon.com>
    Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
    Message-Id: <1586239989-58305-1-git-send-email-suravee.suthikulpanit@amd.com>
    Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
    Tested-by: Maxim Levitsky <mlevitsk@redhat.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/x86/include/asm/kvm_host.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/arch/x86/include/asm/kvm_host.h
    +++ b/arch/x86/include/asm/kvm_host.h
    @@ -1664,8 +1664,8 @@ void kvm_set_msi_irq(struct kvm *kvm, st
    static inline bool kvm_irq_is_postable(struct kvm_lapic_irq *irq)
    {
    /* We can only post Fixed and LowPrio IRQs */
    - return (irq->delivery_mode == dest_Fixed ||
    - irq->delivery_mode == dest_LowestPrio);
    + return (irq->delivery_mode == APIC_DM_FIXED ||
    + irq->delivery_mode == APIC_DM_LOWEST);
    }

    static inline void kvm_arch_vcpu_blocking(struct kvm_vcpu *vcpu)

    \
     
     \ /
      Last update: 2020-05-13 12:09    [W:4.426 / U:0.572 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site