lkml.org 
[lkml]   [2020]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 063/118] usb: chipidea: msm: Ensure proper controller reset using role switch API
    Date
    From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

    commit 91edf63d5022bd0464788ffb4acc3d5febbaf81d upstream.

    Currently we check to make sure there is no error state on the extcon
    handle for VBUS when writing to the HS_PHY_GENCONFIG_2 register. When using
    the USB role-switch API we still need to write to this register absent an
    extcon handle.

    This patch makes the appropriate update to ensure the write happens if
    role-switching is true.

    Fixes: 05559f10ed79 ("usb: chipidea: add role switch class support")
    Cc: stable <stable@vger.kernel.org>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Philipp Zabel <p.zabel@pengutronix.de>
    Cc: linux-usb@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Cc: Stephen Boyd <swboyd@chromium.org>
    Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
    Signed-off-by: Peter Chen <peter.chen@nxp.com>
    Link: https://lore.kernel.org/r/20200507004918.25975-2-peter.chen@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/chipidea/ci_hdrc_msm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/chipidea/ci_hdrc_msm.c
    +++ b/drivers/usb/chipidea/ci_hdrc_msm.c
    @@ -114,7 +114,7 @@ static int ci_hdrc_msm_notify_event(stru
    hw_write_id_reg(ci, HS_PHY_GENCONFIG_2,
    HS_PHY_ULPI_TX_PKT_EN_CLR_FIX, 0);

    - if (!IS_ERR(ci->platdata->vbus_extcon.edev)) {
    + if (!IS_ERR(ci->platdata->vbus_extcon.edev) || ci->role_switch) {
    hw_write_id_reg(ci, HS_PHY_GENCONFIG_2,
    HS_PHY_SESS_VLD_CTRL_EN,
    HS_PHY_SESS_VLD_CTRL_EN);

    \
     
     \ /
      Last update: 2020-05-13 12:00    [W:4.519 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site