Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH 06/11] powerpc/xmon: constify sysrq_key_op | Date | Thu, 14 May 2020 13:44:46 +1000 |
| |
Emil Velikov <emil.l.velikov@gmail.com> writes: > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-kernel@vger.kernel.org > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better if this gets merged this via the tty tree.
Fine by me.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
> diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c > index 7af840c0fc93..0d8ca5c9f131 100644 > --- a/arch/powerpc/xmon/xmon.c > +++ b/arch/powerpc/xmon/xmon.c > @@ -3842,7 +3842,7 @@ static void sysrq_handle_xmon(int key) > xmon_init(0); > } > > -static struct sysrq_key_op sysrq_xmon_op = { > +static const struct sysrq_key_op sysrq_xmon_op = { > .handler = sysrq_handle_xmon, > .help_msg = "xmon(x)", > .action_msg = "Entering xmon", > -- > 2.25.1
| |