lkml.org 
[lkml]   [2020]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] kobject: Make sure the parent does not get released before its children
    On Wed, May 13, 2020 at 8:18 AM Heikki Krogerus
    <heikki.krogerus@linux.intel.com> wrote:
    >
    > In the function kobject_cleanup(), kobject_del(kobj) is
    > called before the kobj->release(). That makes it possible to
    > release the parent of the kobject before the kobject itself.
    >
    > To fix that, adding function __kboject_del() that does
    > everything that kobject_del() does except release the parent
    > reference. kobject_cleanup() then calls __kobject_del()
    > instead of kobject_del(), and separately decrements the
    > reference count of the parent kobject after kobj->release()
    > has been called.
    >
    > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
    > Reported-by: kernel test robot <rong.a.chen@intel.com>
    > Fixes: 7589238a8cf3 ("Revert "software node: Simplify software_node_release() function"")
    > Cc: Brendan Higgins <brendanhiggins@google.com>
    > Cc: Randy Dunlap <rdunlap@infradead.org>
    > Suggested-by: "Rafael J. Wysocki" <rafael@kernel.org>
    > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

    Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
    Tested-by: Brendan Higgins <brendanhiggins@google.com>

    \
     
     \ /
      Last update: 2020-05-13 23:32    [W:3.026 / U:0.588 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site