Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: x86/smp: adding new trace points | Date | Wed, 13 May 2020 18:43:32 +0200 |
| |
Wojciech Kudla <wk.kernel@gmail.com> writes: > On 13/05/2020 13:24, Thomas Gleixner wrote: > >> Why would the SMP call function single interrupt go through the >> PLATFORM_IPI_VECTOR? It goes as the name says through the >> CALL_FUNCTION_SINGLE_VECTOR. >> > > Wrong vector, my bad. > > However 2) still stands in my opinion. We don't have "ipi raise" trace > point for x86. RESCHEDULE_VECTOR, CALL_FUNCTION_SINGLE_VECTOR, as > well as TLB invalidation vectors are essentially > inter-processor-interrupts if I'm not mistaken. Would a patch adding > such trace point be considered here?
Maybe.
Though that IPI tracing is inconsistent across architectures. I'm not really interested to have yet another x86 variant which is slightly different than anything else.
ARM and ARM64 share generic tracepoints for that, though the actual tracepoint invocation is in the architecture specific code.
If at all we really want to have the common IPIs which are required for SMP support covered by generic tracepoints and have them in the generic code and not sprinkled all over arch/*
Thanks,
tglx
| |