Messages in this thread | | | Subject | Re: [PATCH net-next 3/4] net: ethernet: introduce phy_set_pause | From | Doug Berger <> | Date | Tue, 12 May 2020 11:46:20 -0700 |
| |
On 5/11/2020 5:51 PM, Andrew Lunn wrote: > On Mon, May 11, 2020 at 05:24:09PM -0700, Doug Berger wrote: >> This commit introduces the phy_set_pause function to the phylib as >> a helper to support the set_pauseparam ethtool method. >> >> It is hoped that the new behavior introduced by this function will >> be widely embraced and the phy_set_sym_pause and phy_set_asym_pause >> functions can be deprecated. Those functions are retained for all >> existing users and for any desenting opinions on my interpretation >> of the functionality. > > It would be good to add comments to phy_set_sym_pause and > phy_set_asym_pause indicating they are deprecated and point to > phy_set_pause(). > > Andrew >
To be clear, this patch set reflects the pauseparam implementation I desire for the bcmgenet driver. I attempted to implement it as a common phylib service with the hope that it would help other network driver maintainers add support for pause in a common way.
I would like to get feedback/consensus that it is desirable behavior for other drivers to implement before promoting the change of existing implementations.
In particular, I would like to know Russell King's opinion since he has clearly observed (and documented) the short comings of current implementations as part of his phylink work.
If others agree with this being the way to move forward, I will submit another revision with your suggested comments about deprecation within the specified functions.
Thanks for the feedback, Doug
| |