Messages in this thread | | | Date | Tue, 12 May 2020 21:31:59 +0300 | From | Serge Semin <> | Subject | Re: [PATCH v2 1/2] dt-bindings: memory: Add Baikal-T1 L2-cache Control Block binding |
| |
On Mon, May 11, 2020 at 05:37:41PM -0500, Rob Herring wrote: > On Mon, May 11, 2020 at 3:25 PM Serge Semin > <Sergey.Semin@baikalelectronics.ru> wrote: > > > > On Mon, May 11, 2020 at 10:38:04AM -0500, Rob Herring wrote: > > > On Fri, 8 May 2020 02:07:03 +0300, Serge Semin wrote: > > > > There is a single register provided by the SoC system controller, > > > > which can be used to tune the L2-cache RAM up. It only provides a way > > > > to change the L2-RAM access latencies. So aside from "be,bt1-l2-ctl" > > > > compatible string the device node can be optionally equipped with the > > > > properties of Tag/Data/WS latencies. > > > > > > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > > > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > > > > Cc: Paul Burton <paulburton@kernel.org> > > > > Cc: Ralf Baechle <ralf@linux-mips.org> > > > > Cc: Olof Johansson <olof@lixom.net> > > > > Cc: Boris Brezillon <bbrezillon@kernel.org> > > > > Cc: Paul Cercueil <paul@crapouillou.net> > > > > Cc: Thomas Gleixner <tglx@linutronix.de> > > > > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > > > > Cc: linux-mips@vger.kernel.org > > > > Cc: soc@kernel.org > > > > > > > > --- > > > > > > > > Changelog v2: > > > > - Move driver to the memory subsystem. > > > > - Use dual GPL/BSD license. > > > > - Use single lined copyright header. > > > > - Move "allOf" restrictions to the root level of the properties. > > > > - Discard syscon compatible string and reg property. > > > > - The DT node is supposed to be a child of the Baikal-T1 system controller > > > > node. > > > > --- > > > > .../memory-controllers/baikal,bt1-l2-ctl.yaml | 59 +++++++++++++++++++ > > > > 1 file changed, 59 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/memory-controllers/baikal,bt1-l2-ctl.yaml > > > > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > [nip] ... > > > > > > See https://patchwork.ozlabs.org/patch/1285665 > > > > > > If you already ran 'make dt_binding_check' and didn't see the above > > > error(s), then make sure dt-schema is up to date: > > > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > > > Please check and re-submit. > > > > > > > The problem is due to an absent vendor prefix in the test kernel source tree > > environment. As I said in the cover-letter the new vendor prefix will be added > > in the framework of the next patchset: > > https://lkml.org/lkml/2020/5/6/1047 > > > > Rob, please review that patchset first, merge in the corresponding patch from > > there and test this binding out then. > > Did you read the part about a 'bot'? My bot doesn't read cover letters > and I only occasionally do. Do you want to write me a script that can > do this?
A script, that would read a cover-letter for you? =) Anyway I wasn't talking to the bot, but to you explaining why the problem happened and of how to solve it. I didn't mean to blame you or the 'bot' for not reading the letter. Sorry, if it seemed like I did.
-Sergey
> > Rob
| |