lkml.org 
[lkml]   [2020]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH][next] pstore/zone: remove redundant initializations to variable ret
Date
From: Colin Ian King <colin.king@canonical.com>

The variable rc is being initialized with a value that is never read and it
is being updated later with a new value. The initialization is redundant
and can be removed. In one of the cases, ret can also be moved inside a
for-loop to reduce the scope.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/pstore/zone.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/pstore/zone.c b/fs/pstore/zone.c
index 3cf7d6762c76..419de481c69c 100644
--- a/fs/pstore/zone.c
+++ b/fs/pstore/zone.c
@@ -600,7 +600,7 @@ static int psz_recover_zones(struct psz_context *cxt,
*/
static inline int psz_recovery(struct psz_context *cxt)
{
- int ret = -EBUSY;
+ int ret;

if (atomic_read(&cxt->recovered))
return 0;
@@ -746,13 +746,13 @@ static void psz_write_kmsg_hdr(struct pstore_zone *zone,
static inline int notrace psz_kmsg_write_record(struct psz_context *cxt,
struct pstore_record *record)
{
- int ret = -EBUSY;
size_t size, hlen;
struct pstore_zone *zone;
unsigned int i;

for (i = 0; i < cxt->kmsg_max_cnt; i++) {
unsigned int zonenum, len;
+ int ret;

zonenum = (cxt->kmsg_write_cnt + i) % cxt->kmsg_max_cnt;
zone = cxt->kpszs[zonenum];
--
2.25.1
\
 
 \ /
  Last update: 2020-05-12 19:39    [W:1.206 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site